New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Add DimlessBinaryDirective #20972

Merged
merged 3 commits into from Mar 23, 2018

Conversation

Projects
None yet
4 participants
@ricardoasmarques
Copy link
Member

ricardoasmarques commented Mar 20, 2018

This PR adds a directive that can be used to provide a "size" input to the user.

screenshot from 2018-03-20 10-28-11

To use this directive, you can try the following code:

<input cdDimlessBinary [(ngModel)]="model" [ngModelOptions]="{ updateOn: 'blur' }">

<pre>{{ model }}</pre>

Signed-off-by: Ricardo Marques rimarques@suse.com

export class DimlessBinaryDirective implements OnInit {

@Output() ngModelChange: EventEmitter<any> = new EventEmitter();
@Input() minBytes: number;

This comment has been minimized.

@votdev

votdev Mar 21, 2018

Contributor

Can you please explain the input variables and how to use them, e.g. explain what values should/can be used.

This comment has been minimized.

@ricardoasmarques

ricardoasmarques Mar 21, 2018

Author Member

I've added documentation for component inputs.

ricardoasmarques added some commits Mar 21, 2018

mgr/dashboard: Add support for EiB-YiB on dimless-binary.pipe
Signed-off-by: Ricardo Marques <rimarques@suse.com>
mgr/dashboard: Add support for EiB-YiB on dimless.pipe
Signed-off-by: Ricardo Marques <rimarques@suse.com>

@ricardoasmarques ricardoasmarques force-pushed the ricardoasmarques:wip-dimless-binary-directive branch 2 times, most recently from aa5294a to fd33198 Mar 21, 2018

@votdev

votdev approved these changes Mar 22, 2018

@votdev

This comment has been minimized.

Copy link
Contributor

votdev commented Mar 22, 2018

LGTM

@ricardoasmarques ricardoasmarques force-pushed the ricardoasmarques:wip-dimless-binary-directive branch from fd33198 to f184d99 Mar 22, 2018

@tspmelo
Copy link
Contributor

tspmelo left a comment

lgtm

@@ -97,4 +97,5 @@ export class FormatterService {
}
return bytes;
}

This comment has been minimized.

@tspmelo

tspmelo Mar 23, 2018

Contributor

You should remove this change.

This comment has been minimized.

@ricardoasmarques

ricardoasmarques Mar 23, 2018

Author Member

Good point. Done.

mgr/dashboard: Add DimlessBinaryDirective
Signed-off-by: Ricardo Marques <rimarques@suse.com>

@ricardoasmarques ricardoasmarques force-pushed the ricardoasmarques:wip-dimless-binary-directive branch from f184d99 to 134fab7 Mar 23, 2018

@rjfd rjfd merged commit 9a031ba into ceph:master Mar 23, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment