Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Convert the RBD feature names to a list of strings #21024

Merged
merged 1 commit into from Mar 27, 2018

Conversation

Projects
None yet
6 participants
@s0nea
Copy link
Member

commented Mar 23, 2018

Until now the API returns the features provided by an RBD as one comma separated string. It's more usable for the frontend to receive a list of strings instead.

Signed-off-by: Tatjana Dehler tdehler@suse.com

@Devp00l
Copy link
Contributor

left a comment

lgtm

@ricardoasmarques
Copy link
Member

left a comment

Lgtm

@votdev

votdev approved these changes Mar 26, 2018

mgr/dashboard: convert RBD features to a list of strings
Until now the API returns the features provided by an RBD as one comma
separated string. It's more usable for the frontend to receive a list
of strings instead.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>

@s0nea s0nea force-pushed the s0nea:wip-dashboard-return-features-list branch from 9d18f0a to 33e15ec Mar 26, 2018

@LenzGr

LenzGr approved these changes Mar 26, 2018

Copy link
Contributor

left a comment

LGTM. Like for so many other things, it would be nice if Ceph would actually provide us with a list of available features itself rather than having to maintain a separate list here. But that's a different issue.

@LenzGr LenzGr merged commit d5e54fd into ceph:master Mar 27, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@s0nea s0nea deleted the s0nea:wip-dashboard-return-features-list branch Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.