Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: add 'ceph osd pool get erasure allow_ec_overwrites' command #21102

Merged
merged 1 commit into from Apr 11, 2018

Conversation

@trociny
Copy link
Contributor

commented Mar 28, 2018

Fixes: https://tracker.ceph.com/issues/23487
Signed-off-by: Mykola Golub mgolub@suse.com

@trociny trociny added the mon label Mar 28, 2018

@trociny

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2018

It is a little unfortunate that we use 'allow_ec_overwrites' in set command, but 'ec_overwrites' as a flag name, so we can't process it as we do with other flags. Also when we are dumping pool flags (e.g. in ceph osd dump) the name 'ec_overwrites' is used. I would prefer we used the same name everywhere but it looks like too late to change.

@trociny trociny force-pushed the trociny:wip-23487 branch from 100f24a to ce561ea Mar 28, 2018

@gregsfortytwo
Copy link
Member

left a comment

Reviewed-by: Greg Farnum gfarnum@redhat.com

@liewegas liewegas merged commit 68446cc into ceph:master Apr 11, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.