Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: some improvements to ceph-conf.rst #21268

Merged
merged 2 commits into from Apr 12, 2018

Conversation

Projects
None yet
4 participants
@smithfarm
Copy link
Contributor

commented Apr 6, 2018

The "Config file section names" section was duplicating some of the content that is now covered better by the "Configuration sections" section.

RGW configuration goes in the "client" section, which is not intuitive, so mention that.

doc: ceph-conf: RGW configuration goes in "client" section
Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm requested review from liewegas, gregsfortytwo and jcsp Apr 6, 2018

@LenzGr

LenzGr approved these changes Apr 6, 2018

Copy link
Contributor

left a comment

LGTM

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2018

jenkins build docs

@jcsp

jcsp approved these changes Apr 6, 2018

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2018

jenkins render docs

@ceph-jenkins

This comment has been minimized.

Copy link
Collaborator

commented Apr 6, 2018

Doc render available at http://docs.ceph.com/ceph-prs/21268/

doc: ceph-conf: eliminate duplicate verbiage
The "Config file section names" section was duplicating some of the content
that is now covered better by the "Configuration sections" section.

Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm force-pushed the smithfarm:wip-doc-config-ceph branch from 52a0083 to 97fb840 Apr 6, 2018

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2018

Changelog:

  • very minor tweak (addition of ", above" inside the parenthetical)
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2018

retest this please

@smithfarm smithfarm merged commit fd32bcf into ceph:master Apr 12, 2018

4 of 5 checks passed

make check (arm64) make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-doc-config-ceph branch Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.