Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: cmake/modules/BuildRocksDB.cmake: enable compressions for rocksdb #22183

Merged
merged 1 commit into from May 24, 2018

Conversation

Projects
None yet
2 participants
@tchaikov
Copy link
Contributor

commented May 23, 2018

we should enable them if they are found.

currently, we don't have bzip2 compressor plugin, so it's not detected
in the cmake script. we can always enable it for rocksdb in future.

Fixes: http://tracker.ceph.com/issues/24025
Signed-off-by: Kefu Chai kchai@redhat.com
(cherry picked from commit d0b7b52)

@tchaikov tchaikov added this to the mimic milestone May 23, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2018

backport of #22181

@tchaikov tchaikov added the needs-qa label May 23, 2018

cmake/modules/BuildRocksDB.cmake: enable compressions for rocksdb
we should enable them if they are found.

currently, we don't have bzip2 compressor plugin, so it's not detected
in the cmake script. we can always enable it for rocksdb in future.

Fixes: http://tracker.ceph.com/issues/24025
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 71462dd)

@tchaikov tchaikov force-pushed the tchaikov:mimic-24025 branch from 6693a4b to 0bc8784 May 23, 2018

@tchaikov

This comment has been minimized.

@tchaikov tchaikov requested review from liewegas and rzarzynski May 24, 2018

@tchaikov tchaikov added needs-review and removed needs-qa labels May 24, 2018

@tchaikov tchaikov merged commit d81c858 into ceph:mimic May 24, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:mimic-24025 branch May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.