Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mon/OSDMonitor: no_reply on MOSDFailure messages #22297

Merged
merged 2 commits into from Jul 6, 2018

Conversation

Projects
None yet
5 participants
@tchaikov
Copy link
Contributor

commented May 29, 2018

liewegas added some commits May 27, 2018

mon/OSDMonitor: no_reply on ignored MOSDFailure
If we are ignoring the message, tell the forwarding mon to discard it's
state.

Fixes: http://tracker.ceph.com/issues/24322
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 69d9599)
mon/OSDMonitor: no_reply on MOSDFailure ops we eventually process
Failure ops get attached to the failure report.  Once we finally process
them, mark them no_reply so that the forwarding mon will know about it.
The other paths through prepare_failure() do no_reply on the messages
that don't get logged in the failure_info_t::reporters.

Fixes: http://tracker.ceph.com/issues/24322
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit f6128e5)

@tchaikov tchaikov added this to the mimic milestone May 29, 2018

@tchaikov tchaikov requested a review from liewegas May 29, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2018

@jdurgin

jdurgin approved these changes Jul 6, 2018

@yuriw yuriw merged commit e367974 into ceph:mimic Jul 6, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:mimic-24322 branch Jul 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.