Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: rgwgc:process coredump in some special case。 #22520

Closed
wants to merge 4 commits into from

Conversation

@cethikdata
Copy link
Contributor

cethikdata commented Jun 12, 2018

rgw: rgwgc:process coredump in some special case。 Gc processes obja, objb, objc in order and pool of objb is deleted (obja and objc is in the same pool and pool exits). RGW will coredump as ctx->io_ctx_impl is an empty point during delete objc.
Fixes:http://tracker.ceph.com/issues/23199

Signed-off-by: zhaokun develop@hikdata.com

…objb, objc in order and pool of objb is deleted (objb and objc is in the same pool and pool exits). RGW will coredump as ctx->io_ctx_impl is an empty point during delete objc.

Fixes:http://tracker.ceph.com/issues/23199

Signed-off-by: zhaokun <develop@hikdata.com>
@charmingcow

This comment has been minimized.

Copy link

charmingcow commented Jun 12, 2018

good work

Copy link
Contributor

mattbenjamin left a comment

lgtm, spacing fix

@@ -313,6 +313,7 @@ int RGWGC::process(int index, int max_secs, bool expired_only,
ctx = new IoCtx;
ret = rgw_init_ioctx(store->get_rados_handle(), obj.pool, *ctx);
if (ret < 0) {
last_pool = "";

This comment has been minimized.

Copy link
@mattbenjamin

mattbenjamin Jun 12, 2018

Contributor

fix spacing

cethikdata and others added 3 commits Jun 13, 2018
fix space
Signed-off-by: zhaokun <develop@hikdata.com>
fix space
Signed-off-by: zhaokun <develop@hikdata.com>
@cethikdata cethikdata closed this Jun 13, 2018
@charmingcow

This comment has been minimized.

Copy link

charmingcow commented Jun 13, 2018

a good suggest of string use should be such as : string empty() etc ...

@cethikdata

This comment has been minimized.

Copy link
Contributor Author

cethikdata commented Jun 13, 2018

sorry, the format of commit message is not right. So i close this pull-request and start a new one (22539).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.