New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr: replace iteritems with six.iteritems #22870
Conversation
4a39068
to
76c987a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for Influx and Telegraf
As @tchaikov noticed that dashboard is already using six (even though we don't formally have the dependency), maybe we should use six here and make it official? At the point we're handling things like iteritems lots of places it seems worthwhile. ceph-mgr already depends on six indirectly (via python-bcrypt's dependency), so this is not a big jump |
@jcsp OK, I'll limit the PR to |
@jcsp Migration to six complete: please have a look? |
Fixes: http://tracker.ceph.com/issues/24779 Signed-off-by: Nathan Cutler <ncutler@suse.com>
Fixes: http://tracker.ceph.com/issues/24779 Signed-off-by: Nathan Cutler <ncutler@suse.com>
Fixes: http://tracker.ceph.com/issues/24779 Signed-off-by: Nathan Cutler <ncutler@suse.com>
Fixes: http://tracker.ceph.com/issues/24779 Signed-off-by: Nathan Cutler <ncutler@suse.com>
Fixes: http://tracker.ceph.com/issues/24779 Signed-off-by: Nathan Cutler <ncutler@suse.com>
Fixes: http://tracker.ceph.com/issues/24779 Signed-off-by: Nathan Cutler <ncutler@suse.com>
Fixes: http://tracker.ceph.com/issues/24779 Signed-off-by: Nathan Cutler <ncutler@suse.com>
* refs/pull/22870/head: mgr: replace iteritems with six.iteritems (mgr_module.py) mgr: replace iteritems with six.iteritems (crash) mgr: replace iteritems with six.iteritems (telegraf) mgr: replace iteritems with six.iteritems (status) mgr: replace iteritems with six.iteritems (restful) mgr: replace iteritems with six.iteritems (influx) mgr: replace iteritems with six.iteritems (balancer) Reviewed-by: John Spray <john.spray@redhat.com> Reviewed-by: Wido den Hollander <wido@42on.com> Reviewed-by: Kefu Chai <kchai@redhat.com>
Fixes: http://tracker.ceph.com/issues/24779
Signed-off-by: Nathan Cutler ncutler@suse.com