New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: qa: test_recovery_pool tries asok on wrong node #23087

Merged
merged 3 commits into from Oct 19, 2018

Conversation

Projects
None yet
5 participants
@pdvian
Copy link

pdvian commented Jul 17, 2018

@pdvian

This comment has been minimized.

Copy link

pdvian commented Jul 17, 2018

@batrick Shall I wait for PR #21885 changes to be merged to mimic ? I had to resolve changes manually for setupfs.

@smithfarm smithfarm added the cephfs label Jul 17, 2018

@smithfarm smithfarm requested a review from batrick Jul 17, 2018

@smithfarm smithfarm added this to the mimic milestone Jul 17, 2018

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Aug 20, 2018

@batrick Ping - two questions here:

  1. is #21885 eligible for mimic backport? (I guess these cherry-picks would apply cleanly if #21885 were backported first?)
  2. if no, then is the conflict resolution in this PR OK?
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Aug 20, 2018

Ah, now I see that mimic backport of #21885 is already open #23105

Marking this one DNM for now

@smithfarm smithfarm added the DNM label Aug 20, 2018

@smithfarm smithfarm changed the title mimic: qa: test_recovery_pool tries asok on wrong node [DNM] mimic: qa: test_recovery_pool tries asok on wrong node Aug 20, 2018

@batrick

This comment has been minimized.

Copy link
Member

batrick commented Sep 13, 2018

PR #23105 is merged. Please rebase.

batrick added some commits Jul 10, 2018

qa: run asok command on correct machine
The MDS may not be on the same machine where the cluster command is run.

Fixes: http://tracker.ceph.com/issues/24858

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit fa25d6c)
qa: remove dead code
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit a2ff87d)
qa: optionally use old fs name during cephfs remount
This fixes errors caused by remount done by some tests (test_recovery_pool.py)
where the fs name is not given.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 1ad8d86)

@pdvian pdvian force-pushed the pdvian:wip-24928-mimic branch from 603e4c5 to bb52297 Sep 18, 2018

@pdvian

This comment has been minimized.

Copy link

pdvian commented Sep 18, 2018

@batrick kindly review.

@batrick batrick changed the title [DNM] mimic: qa: test_recovery_pool tries asok on wrong node mimic: qa: test_recovery_pool tries asok on wrong node Sep 18, 2018

@batrick batrick removed the DNM label Sep 18, 2018

@batrick

This comment has been minimized.

Copy link
Member

batrick commented Sep 18, 2018

retest this please

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 15, 2018

@yuriw yuriw merged commit 95b3476 into ceph:mimic Oct 19, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment