New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard config options add #23230

Merged
merged 10 commits into from Oct 9, 2018

Conversation

@s0nea
Contributor

s0nea commented Jul 25, 2018

This PR adds the following functionalities:

Backend:

  • refactor of '_get_mon_allow_pool_delete_config' to be more general
  • backend functionality to add config options + related tests

Frontend:

  • a config options form
  • a placeholder for filters (dropdown menu) to the dashboard datatable
  • a fix for an import issue in configuration.component.spec.ts
  • a fix for a typo in monitors.e2e-spec.ts
  • the missing parameter type to an existing configuration service method and a related test
  • frontend functionality to add config options + related tests
  • pattern validators for IP-addresses, UUIDs, numbers and decimal numbers
  • moved the configuration table details to their own component

ToDo:
This PR is just a first step in order to manage config options. Of course there are a bunch of things still missing.They should be handled in separate PRs in my opinion. I will update the list and create issues as soon as possible.

Signed-off-by: Tatjana Dehler tdehler@suse.com

@s0nea s0nea force-pushed the s0nea:wip-dashboard-config-options-add branch from 9cbb663 to a5745d1 Jul 25, 2018

@sebastian-philipp

This comment has been minimized.

Member

sebastian-philipp commented Jul 26, 2018

Don't confuse with #22457

@s0nea s0nea force-pushed the s0nea:wip-dashboard-config-options-add branch 3 times, most recently from ada6b73 to 38f08d6 Jul 26, 2018

@s0nea s0nea force-pushed the s0nea:wip-dashboard-config-options-add branch 6 times, most recently from 770618a to c7eac52 Aug 3, 2018

@s0nea s0nea force-pushed the s0nea:wip-dashboard-config-options-add branch 12 times, most recently from b1258f2 to 2abf8c8 Aug 13, 2018

@s0nea s0nea force-pushed the s0nea:wip-dashboard-config-options-add branch 4 times, most recently from 2f74370 to 9e79900 Aug 21, 2018

@s0nea s0nea force-pushed the s0nea:wip-dashboard-config-options-add branch 3 times, most recently from a675da8 to f7571f5 Oct 8, 2018

@s0nea

This comment has been minimized.

Contributor

s0nea commented Oct 8, 2018

jenkins test make check

@s0nea s0nea force-pushed the s0nea:wip-dashboard-config-options-add branch from f7571f5 to bc8a4a2 Oct 8, 2018

@ricardoasmarques

This comment has been minimized.

Member

ricardoasmarques commented Oct 8, 2018

Apparently something is broken:

screenshot from 2018-10-08 15-33-50

@s0nea s0nea force-pushed the s0nea:wip-dashboard-config-options-add branch from bc8a4a2 to 36c7d14 Oct 8, 2018

@s0nea

This comment has been minimized.

Contributor

s0nea commented Oct 9, 2018

jenkins test make check

@s0nea

This comment has been minimized.

Contributor

s0nea commented Oct 9, 2018

jenkins test make check arm64

@Devp00l

Devp00l approved these changes Oct 9, 2018

Thank you for addressing all my comments 👍

@s0nea s0nea force-pushed the s0nea:wip-dashboard-config-options-add branch from 36c7d14 to 8774d77 Oct 9, 2018

@s0nea s0nea force-pushed the s0nea:wip-dashboard-config-options-add branch from 8774d77 to b3cc490 Oct 9, 2018

s0nea added some commits Jun 29, 2018

mgr/dashboard: refactor '_get_mon_allow_pool_delete_config'
Refactor '_get_mon_allow_pool_delete_config' method to be a little bit
more general. The method can now be used to get the value of every
config option known to the cluster.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
mgr/dashboard: fix missing import
Added the missing import otherwise the 'should create' test will fail
because the received component is undefined.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
mgr/dashboard: fix typo
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
mgr/dashboard: add placeholder for filters to datatable
As (e.g.) the configuration option documentation has dropdown menus
with pre-defined filters we need a placeholder for them in the
datatable.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
mgr/dashboard: add pattern validators
Add some pattern validators (ip, uuid, number, decimalNumber) that
are needed to validate the config option input values.

Fixes: http://tracker.ceph.com/issues/24455

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
mgr/dashboard: add config options form
Fixes: http://tracker.ceph.com/issues/24455

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
mgr/dashboard: add missing parameter type and related test
Added missing parameter type and a test for this service method.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
mgr/dashboard: add create functionality to the frontend
Add the missing functionality to create config options and related
tests to the frontend.

Fixes: http://tracker.ceph.com/issues/24455

Signed-off-by: Tatjana Dehler <tdehler@suse.com>

@s0nea s0nea force-pushed the s0nea:wip-dashboard-config-options-add branch from b3cc490 to 960c17a Oct 9, 2018

@ricardoasmarques ricardoasmarques merged commit 35cc77d into ceph:master Oct 9, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment