New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: core: librados application's symbol could conflict with the libceph-common #23483

Merged
merged 2 commits into from Oct 5, 2018

Conversation

Projects
None yet
4 participants
@pdvian

pdvian commented Aug 8, 2018

tchaikov added some commits Jul 30, 2018

cmake: always prefer local symbols
Fixes: http://tracker.ceph.com/issues/25154
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 38e3446)
test: use death_test_style="threadsafe" for Mutex.NormalAsserts
use threadsafe for running the Mutex assert test to run the test from
beginning to avoid the hang. this test overrides the symbol of
ceph::__ceph_assert_fail() with a local one offered by the application
links against libceph-common. but we intentionally forbid this behavior:
we do not allow libceph-common to reference the symbols exposed from
application with the same name. see http://tracker.ceph.com/issues/25154

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 1739d6b)

@smithfarm smithfarm added this to the luminous milestone Oct 3, 2018

@smithfarm smithfarm requested review from aclamk, tchaikov and cbodley Oct 3, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Oct 4, 2018

@yuriw yuriw merged commit 9b2057c into ceph:luminous Oct 5, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title from luminous: librados application's symbol could conflict with the libceph-common to luminous: core: librados application's symbol could conflict with the libceph-common Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment