Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: data sync respects error_retry_time for backoff on error_repo #23571

Merged
merged 3 commits into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@cbodley
Copy link
Contributor

commented Aug 14, 2018

don't restart processing the error_repo until error_retry_time. when data sync is otherwise idle, don't sleep past error_retry_time

Fixes: http://tracker.ceph.com/issues/26938

@cbodley cbodley requested a review from yehudasa Aug 14, 2018

@cbodley

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2018

@yehudasa
Copy link
Member

left a comment

see my comments, but otherwise ok

@@ -181,6 +181,14 @@ namespace ceph {
return from_timespec(ts);
}

static bool is_zero(const time_point& t) {
return (t == time_point::min());

This comment has been minimized.

Copy link
@yehudasa

yehudasa Sep 7, 2018

Member

nit: indentation?

This comment has been minimized.

Copy link
@yehudasa

yehudasa Sep 7, 2018

Member

or maybe just github issues with tabs/spaces?

This comment has been minimized.

Copy link
@cbodley

cbodley Sep 7, 2018

Author Contributor

yeah, i just copied the tab formatting used elsewhere in the file

cbodley added some commits Aug 14, 2018

rgw: data sync uses coarse clock for error_retry_time
Signed-off-by: Casey Bodley <cbodley@redhat.com>
common: adding missing ceph::coarse_real_clock helpers
Signed-off-by: Casey Bodley <cbodley@redhat.com>
rgw: data sync respects error_retry_time for backoff on error_repo
don't restart processing the error_repo until error_retry_time. when
data sync is otherwise idle, don't sleep past error_retry_time

Fixes: http://tracker.ceph.com/issues/26938

Signed-off-by: Casey Bodley <cbodley@redhat.com>

@cbodley cbodley force-pushed the cbodley:wip-26938 branch from 6915c79 to eb65532 Sep 7, 2018

@cbodley cbodley merged commit 97e4db9 into ceph:master Sep 7, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@cbodley cbodley deleted the cbodley:wip-26938 branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.