New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: osd: OSDMap: fix apply upmap segfault #23579

Merged
merged 2 commits into from Sep 12, 2018

Conversation

Projects
None yet
6 participants
@VictorDenisov
Contributor

VictorDenisov commented Aug 15, 2018

http://tracker.ceph.com/issues/26934

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

badone added some commits Aug 3, 2018

osd/OSDMap: Disallow negative values in _apply_upmap
A negative pg_upmap or pg_upmap_item value can cause a segfault so
ignore them.

Fixes: http://tracker.ceph.com/issues/22056

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit 689e1cf)
TestOSDMap: Test with negative upmap values
Check we can handle negative pg_upmap and pg_upmap_items values.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit f76c889)

@tchaikov tchaikov added this to the luminous milestone Aug 15, 2018

@liewegas liewegas changed the title from osd/OSDMap: fix apply upmap segfault to luminous: osd/OSDMap: fix apply upmap segfault Aug 18, 2018

@smithfarm smithfarm requested review from badone, jdurgin and liewegas Aug 20, 2018

@smithfarm smithfarm added the core label Aug 20, 2018

@badone

badone approved these changes Aug 20, 2018

LGTM

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 11, 2018

@VictorDenisov

This comment has been minimized.

Contributor

VictorDenisov commented Sep 12, 2018

@yuriw Is it something I need to look at? It doesn't seem that I have access to it.

@yuriw yuriw merged commit 84118de into ceph:luminous Sep 12, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@VictorDenisov VictorDenisov deleted the VictorDenisov:backport_26934 branch Sep 14, 2018

@smithfarm smithfarm changed the title from luminous: osd/OSDMap: fix apply upmap segfault to luminous: osd: OSDMap: fix apply upmap segfault Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment