New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: mds: crash when dumping ops in flight #23677

Merged
merged 2 commits into from Sep 17, 2018

Conversation

Projects
None yet
4 participants
@ukernel
Member

ukernel commented Aug 22, 2018

@ukernel ukernel added this to the luminous milestone Aug 22, 2018

ukernel added some commits Aug 15, 2018

mds: hold slave request refernce when dumping MDRequestImpl
dump_ops_in_flight asok command dumps MDRequestImpl without holding
mds_lock. MDS may free MDRequestImpl::slave_request in the middle of
dumping MDRequestImpl.

Fixes: http://tracker.ceph.com/issues/26894
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit 1013374)

 Conflicts:
	src/mds/Mutation.h
	src/mds/Mutation.cc
mds: don't modify filepath when printing
filepath::depth() may call parse_bits(), which modifies mutable member
'bits'. dump_ops_in_flight asok command prints filepath without holding
mds_lock. So multiple threads may call parse_bits() at the same time.

Fixes: http://tracker.ceph.com/issues/26894
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit 0f057fe)

@ukernel ukernel force-pushed the ukernel:luminous-26894 branch from 83167e7 to 1a92b14 Aug 22, 2018

@smithfarm smithfarm requested a review from batrick Aug 22, 2018

@yuriw yuriw removed the 13.2.2 label Aug 27, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 13, 2018

@yuriw yuriw merged commit edcc419 into ceph:luminous Sep 17, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment