New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: rbd: librbd: fix refuse to release lock when cookie is the same at rewatch #23758

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
5 participants
@dillaman
Contributor

dillaman commented Aug 27, 2018

librbd: fix refuse to release lock when cookie is the same at rewatch
  fix exclusive auto-mode lock refuse to release.
  when rewatch, owner_id is reset.
  at the same time, there is a chance to produce the same cookie, which should be different.
  code now skips reacquire lock when the cookie is the same, resulting in unsetting owner_id.
  when other clients request lock, client whose owner_id is null is considered invalid and
  refuse to release lock.
  but unluckily, watcher is always alive, so the client requested lock can't get lock.

Signed-off-by: Song Shun <song.shun3@zte.com.cn>
(cherry picked from commit 51ac193)

@dillaman dillaman added this to the luminous milestone Aug 27, 2018

@trociny

LGTM

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 12, 2018

@yuriw yuriw merged commit 5e2b81e into ceph:luminous Sep 17, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@dillaman dillaman deleted the dillaman:wip-27987 branch Sep 28, 2018

@smithfarm smithfarm changed the title from luminous: librbd: fix refuse to release lock when cookie is the same at rewatch to luminous: rbd: librbd: fix refuse to release lock when cookie is the same at rewatch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment