New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: core: mgr/MgrClient: guard send_pgstats() with lock #23791

Merged
merged 2 commits into from Sep 14, 2018

Conversation

Projects
None yet
6 participants
@tchaikov
Contributor

tchaikov commented Aug 29, 2018

tchaikov added some commits Oct 23, 2017

mgr/MgrClient: extract MMgrReport sending code into a separated method
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 5faf178)

Conflicts:
	src/mgr/MgrClient.h: trivial resolution
mgr/MgrClient: guard send_pgstats() with lock
ms_handle_reset() races with send_pgstats(), and the latter could
reference a session with a null connection. so we need to guard
send_pgstats() with a lock.

Fixes: http://tracker.ceph.com/issues/23370
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit b17ff3c)

@tchaikov tchaikov added this to the luminous milestone Aug 29, 2018

@tchaikov tchaikov requested a review from smithfarm Aug 29, 2018

@smithfarm smithfarm added the core label Aug 29, 2018

@smithfarm smithfarm requested review from jcsp and liewegas and removed request for smithfarm Sep 11, 2018

@jcsp

jcsp approved these changes Sep 11, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 12, 2018

@yuriw yuriw merged commit 6b7471e into ceph:luminous Sep 14, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-23370-luminous branch Sep 15, 2018

@smithfarm smithfarm changed the title from luminous: mgr/MgrClient: guard send_pgstats() with lock to luminous: core: mgr/MgrClient: guard send_pgstats() with lock Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment