New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Move Cluster/Audit logs from front page to dedicated Logs page #23834

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Projects
None yet
8 participants
@DikshaGodbole
Copy link
Contributor

DikshaGodbole commented Aug 31, 2018

@joscollin joscollin changed the title mgr/dashboard: Move Cluster/Audit logs from front page to dedicated Logs page [WIP] mgr/dashboard: Move Cluster/Audit logs from front page to dedicated Logs page Aug 31, 2018

@LenzGr LenzGr requested review from Devp00l , tspmelo , ricardoasmarques and votdev Aug 31, 2018

@LenzGr LenzGr added the needs-review label Aug 31, 2018

@LenzGr
Copy link
Contributor

LenzGr left a comment

"make check" failed with some linting errors, it seems. Please make sure to run npm run prettier to ensure proper formatting of your files. See HACKING.rst for more details.

@LenzGr

This comment has been minimized.

Copy link
Contributor

LenzGr commented Aug 31, 2018

Apart from that, the change looks good as a first mergeable step!

@DikshaGodbole DikshaGodbole force-pushed the DikshaGodbole:wip-feature-24571 branch from c60db76 to d41fd96 Aug 31, 2018

@joscollin

This comment has been minimized.

Copy link
Member

joscollin commented Aug 31, 2018

Jenkins retest this please

@DikshaGodbole DikshaGodbole force-pushed the DikshaGodbole:wip-feature-24571 branch 5 times, most recently from 92847a2 to 296e3e1 Sep 15, 2018

@LenzGr LenzGr added needs-rebase and removed mgr labels Sep 25, 2018

@votdev

This comment has been minimized.

Copy link
Contributor

votdev commented Oct 2, 2018

Please rebase your PR to fix the merge conflict.

@DikshaGodbole DikshaGodbole force-pushed the DikshaGodbole:wip-feature-24571 branch from 296e3e1 to 4f47924 Oct 3, 2018

@votdev votdev removed the needs-rebase label Oct 8, 2018

@DikshaGodbole DikshaGodbole force-pushed the DikshaGodbole:wip-feature-24571 branch 2 times, most recently from bcc377b to f4ff0d3 Oct 10, 2018

@DikshaGodbole DikshaGodbole force-pushed the DikshaGodbole:wip-feature-24571 branch 3 times, most recently from 34d6417 to 7e82c4f Nov 21, 2018

@tspmelo

This comment has been minimized.

Copy link
Contributor

tspmelo commented Nov 21, 2018

Please run 'npm run fix' on frontend directory to fix some of the linting errors.
You will need to manually fix the lint errors of 1 html file, you can find out which with 'npm run lint'.

@DikshaGodbole DikshaGodbole force-pushed the DikshaGodbole:wip-feature-24571 branch 3 times, most recently from 6ef97e9 to 647eab8 Nov 21, 2018

@tspmelo
Copy link
Contributor

tspmelo left a comment

Some minor changes regarding i18n and RouterLinks.

I think you should squash all the commits, all fix the same issue.

@DikshaGodbole DikshaGodbole force-pushed the DikshaGodbole:wip-feature-24571 branch 3 times, most recently from 18fae89 to 5c94caa Nov 22, 2018

@joscollin joscollin changed the title [WIP] mgr/dashboard: Move Cluster/Audit logs from front page to dedicated Logs page mgr/dashboard: Move Cluster/Audit logs from front page to dedicated Logs page Nov 23, 2018

@LenzGr

LenzGr approved these changes Nov 23, 2018

@votdev

This comment has been minimized.

Copy link
Contributor

votdev commented Nov 23, 2018

Redundant information. Please remove the bold AUDIT LOGS: and CLUSTER LOGS: titles.
auswahl_001

@DikshaGodbole DikshaGodbole force-pushed the DikshaGodbole:wip-feature-24571 branch from 5c94caa to 41dc99e Nov 23, 2018

@votdev votdev dismissed their stale review Nov 23, 2018

The cosmetic changes should be done in a separate PR to get this PR merged now.

@LenzGr

This comment has been minimized.

Copy link
Contributor

LenzGr commented Nov 23, 2018

Thanks for removing the titles, looks much better. I would have two remaining requests: can you please change the font to be monospaced again, as it was done before? Also, the text is probably more readable if it would be black on white?

mgr/dashboard: Added new logs component
Added new Logs component and created a cluster->logs menu item. Moved the logs from the dashboard home page to the dedicated logs page.Additional comments resolved.Dropped Logs from health component.

Fixes: https://tracker.ceph.com/issues/24571
Signed-off-by: Diksha Godbole <diksha.godbole@gmail.com>

@DikshaGodbole DikshaGodbole force-pushed the DikshaGodbole:wip-feature-24571 branch from 41dc99e to c8820b8 Nov 23, 2018

@DikshaGodbole

This comment has been minimized.

Copy link
Contributor Author

DikshaGodbole commented Nov 23, 2018

Jenkins retest this please.

@joscollin

This comment has been minimized.

Copy link
Member

joscollin commented Nov 23, 2018

These Jenkins tests are going to fail until it is fixed. We can wait till next week - no other way.

@joscollin

This comment has been minimized.

Copy link
Member

joscollin commented Nov 25, 2018

retest this please

@joscollin

This comment has been minimized.

Copy link
Member

joscollin commented Nov 25, 2018

jenkins test dashboard

@votdev

votdev approved these changes Nov 26, 2018

@LenzGr LenzGr merged commit 924c36d into ceph:master Nov 26, 2018

6 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment