New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: core: rados python bindings use prval from stack #23864

merged 1 commit into from Sep 14, 2018


None yet
5 participants

smithfarm commented Sep 2, 2018

pybind/rados/rados: do not pass prval from stack
The prval is a pointer to an int to write the final completion code of
the rados op.  This can't be on the stack since we immediately leave the
current scope after preparing the op (looong before we do the rados op).

We keep the tuple return value to avoid breaking users of this API
(devicehealth module, gnocchi at a minimum).

Signed-off-by: Sage Weil <>
(cherry picked from commit 8e36f18)

@smithfarm smithfarm self-assigned this Sep 2, 2018

@smithfarm smithfarm added this to the luminous milestone Sep 2, 2018

@smithfarm smithfarm requested review from jcsp and jdurgin Sep 2, 2018


jdurgin approved these changes Sep 5, 2018


jcsp approved these changes Sep 6, 2018


This comment has been minimized.


yuriw commented Sep 12, 2018

@yuriw yuriw merged commit 42a47b3 into ceph:luminous Sep 14, 2018

4 checks passed

Docs: build check OK - docs built
Signed-off-by all commits in this PR are signed
Unmodified Submodules submodules for project are unmodified
make check make check succeeded

@smithfarm smithfarm deleted the smithfarm:wip-25203-luminous branch Sep 14, 2018

@smithfarm smithfarm changed the title from luminous: rados python bindings use prval from stack to luminous: core: rados python bindings use prval from stack Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment