Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: kv: MergeOperator name() returns string, and caller calls c_str() on the temporary #23865

merged 1 commit into from Sep 5, 2018


None yet
4 participants
Copy link

commented Sep 2, 2018

kv/KeyValueDB: return const char* from MergeOperator::name()
This avoids a c_str() on a temporary string later down the line, which
avoids a use-after-free.

Signed-off-by: Sage Weil <>
(cherry picked from commit e9be5da)

@smithfarm smithfarm self-assigned this Sep 2, 2018

@smithfarm smithfarm added this to the mimic milestone Sep 2, 2018

@smithfarm smithfarm requested a review from tchaikov Sep 2, 2018

@smithfarm smithfarm requested a review from jdurgin Sep 2, 2018


This comment has been minimized.

Copy link

commented Sep 2, 2018

@yuriw yuriw merged commit 831a5b1 into ceph:mimic Sep 5, 2018

4 checks passed

Docs: build check OK - docs built
Signed-off-by all commits in this PR are signed
Unmodified Submodules submodules for project are unmodified
make check make check succeeded

@smithfarm smithfarm deleted the smithfarm:wip-26907-mimic branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.