New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: core: object errors found in be_select_auth_object() aren't logged the same #23871

Merged
merged 6 commits into from Sep 14, 2018

Conversation

@smithfarm
Contributor

smithfarm commented Sep 2, 2018

dzafman added some commits Aug 1, 2018

osd: Move object error check out of be_select_auth_object()
Fixes: http://tracker.ceph.com/issues/25108

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit c789fd1)

Conflicts:
	src/osd/PGBackend.cc

- luminous still has auth_prio and different way of decoding bliter
osd: Log shard errors in be_select_auth_object() as other errors
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit cadf727)

Conflicts:
	src/osd/PGBackend.cc

- luminous still has oi_prio
test: Verify cluster logging of scrub error messages
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 58c4d32)
qa: Add new message to whitelist for scrub/repair tests
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit b407842)
osd: Use colon to separate error message from other info
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit bdd32cc)
test: Update tests for error message changes
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 687f63e)

Conflicts:
	qa/standalone/scrub/osd-scrub-snaps.sh

- luminous has two additional errors

@smithfarm smithfarm self-assigned this Sep 2, 2018

@smithfarm smithfarm added this to the luminous milestone Sep 2, 2018

@smithfarm smithfarm requested review from dzafman, liewegas and tchaikov Sep 2, 2018

@smithfarm smithfarm added the tests label Sep 2, 2018

@dzafman

dzafman approved these changes Sep 4, 2018

lgtm

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 12, 2018

@yuriw yuriw merged commit bf25b02 into ceph:luminous Sep 14, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-32106-luminous branch Sep 14, 2018

@smithfarm smithfarm changed the title from luminous: object errors found in be_select_auth_object() aren't logged the same to luminous: core: object errors found in be_select_auth_object() aren't logged the same Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment