New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: mds: MDBalancer::try_rebalance() may stop prematurely #23884

Merged
merged 2 commits into from Sep 19, 2018

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented Sep 2, 2018

@smithfarm smithfarm self-assigned this Sep 2, 2018

@smithfarm smithfarm added this to the luminous milestone Sep 2, 2018

@smithfarm smithfarm requested review from ukernel and batrick Sep 2, 2018

@smithfarm smithfarm added cephfs and removed core labels Sep 2, 2018

@ukernel

ukernel approved these changes Sep 4, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 13, 2018

@batrick

This comment has been minimized.

Member

batrick commented Sep 18, 2018

Needs rebase

@batrick

This comment has been minimized.

Member

batrick commented Sep 18, 2018

Needs rebase. Testing passed.

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 18, 2018

@smithfarm pls merged after rebase

ukernel added some commits Aug 1, 2018

mds: don't queue straydir for split
straydir can not get splitted (for now at least)

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit 959e63c)

Conflicts:
	src/mds/MDBalancer.cc
- finesse split/merge conditional expression
mds: fix premature stop of MDBalancer::try_rebalance()
When mds wants to export loads to multiple targets. The amount of single
export can easily be less than (0.2 * target_loads). For example:

6 active mds, mds.0's load is 11, other ranks' loads are 5. target_load
is 6. Export amount for each target is 1.

Fixes: http://tracker.ceph.com/issues/26973
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit e68cbec)

@ukernel ukernel force-pushed the smithfarm:wip-32084-luminous branch from c3e33a2 to a84a2d9 Sep 19, 2018

@ukernel ukernel merged commit 9a80f2f into ceph:luminous Sep 19, 2018

0 of 4 checks passed

Docs: build check Docs: building
Details
Signed-off-by checking if commits are signed
Details
Unmodified Submodules Build triggered for merge commit.
Details
make check Build triggered for merge commit.
Details

@smithfarm smithfarm deleted the smithfarm:wip-32084-luminous branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment