Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: return x-amz-version-id: null when delete obj in versioning suspended bucket #23927

Merged
merged 1 commit into from Sep 19, 2018
Merged

rgw: return x-amz-version-id: null when delete obj in versioning suspended bucket #23927

merged 1 commit into from Sep 19, 2018

Conversation

joke-lee
Copy link
Contributor

@joke-lee joke-lee commented Sep 5, 2018

in aws

bucket wzyuliyangbucket01 is versioning suspend and we delete the pkbgum.jpg object without VersionId, there will create null version delete marker

DELETE /wzyuliyangbucket01/pkbgum.jpg HTTP/1.1
Host: s3.amazonaws.com
Accept-Encoding: identity
Date: Tue, 04 Sep 2018 01:36:02 GMT
Content-Length: 0
Authorization: AWS AKIAI62ZIFWLOCODA6RA:74p/nZb+S+18U6G+V7rtXliD0Ao=
User-Agent: Boto3/1.7.54 Python/2.7.5 Linux/3.10.0-327.el7.x86_64 Botocore/1.10.54

HTTP/1.1 204 No Content
x-amz-id-2: bPkiiVYz9edjyrIp+GeX514oQXLVMQ8WpgZdJkxDVXeeMZz9fH8pIWrFUxVtMB/+HrxLbraLQ1E=
x-amz-request-id: F9A0A725013FE6E3
Date: Tue, 04 Sep 2018 01:36:18 GMT
x-amz-version-id: null    <===create null version delete marker
x-amz-delete-marker: true
Server: AmazonS3

but in ceph rgw current

DELETE /test1/pkbgum.jpg HTTP/1.1
Host: 192.168.153.177
Accept-Encoding: identity
Date: Tue, 04 Sep 2018 01:33:38 GMT
Content-Length: 0
Authorization: AWS yly:F64fDhEZwHResd6XewYycNf1Jws=
User-Agent: Boto3/1.7.54 Python/2.7.5 Linux/3.10.0-327.el7.x86_64 Botocore/1.10.54

HTTP/1.1 204 No Content
x-amz-delete-marker: true   <=== yes create delete mark  but  no x-amz-version-id
x-amz-request-id: tx000000000000000000045-005b8de0f2-5e25-default
Date: Tue, 04 Sep 2018 01:33:38 GMT

fix http://tracker.ceph.com/issues/35814

Signed-off-by: yuliyang yuliyang@cmss.chinamobile.com

@joke-lee
Copy link
Contributor Author

joke-lee commented Sep 5, 2018

hi @mattbenjamin can you help to review this? thanks

@joke-lee
Copy link
Contributor Author

joke-lee commented Sep 5, 2018

hi @cbodley do you mind help review this?

@cbodley
Copy link
Contributor

cbodley commented Sep 6, 2018

@joke-lee could you please open a tracker issue for mimic/luminous backports?

@joke-lee
Copy link
Contributor Author

joke-lee commented Sep 6, 2018

@cbodley fine

suspended bucket

fix http://tracker.ceph.com/issues/35814

Signed-off-by: yuliyang <yuliyang@cmss.chinamobile.com>
@joke-lee
Copy link
Contributor Author

hi @cbodley , would you mind to add qa test tag to this pr?

@joke-lee
Copy link
Contributor Author

hi @cbodley ,did this passed testing?

@cbodley
Copy link
Contributor

cbodley commented Sep 18, 2018

@joke-lee not yet, other prs in my wip-cbodley-testing branch have been failing. the latest attempt is scheduled at http://pulpito.ceph.com/cbodley-2018-09-18_13:25:30-rgw-wip-cbodley-testing-distro-basic-smithi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants