New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: cephfs: ceph_volume_client: py3 compatible #24083

Merged
merged 7 commits into from Sep 28, 2018

Conversation

Projects
None yet
4 participants
@batrick
Member

batrick commented Sep 13, 2018

@batrick batrick added the cephfs label Sep 13, 2018

@batrick batrick added this to the luminous milestone Sep 13, 2018

@batrick batrick changed the title from I26851 to luminous: ceph_volume_client: py3 compatible Sep 13, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 26, 2018

@batrick pls fix

rishabh-d-dave and others added some commits May 15, 2018

ceph-volume-client: add py3 compatibility
Fixes: http://tracker.ceph.com/issues/17230
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit efdf1af)

Conflicts:
	src/pybind/ceph_volume_client.py
cephfs.pyx: add py3 compatibility
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 5106582)
qa/ceph-volume: allow executing python pyloads using python3
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 2f35ade)

Conflicts:
	qa/tasks/vstart_runner.py
qa: make test_volume_client.py py3 compatible
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit f28274d)
qa: test py2 and py3 for volume client
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit a5e3b05)
packages.yaml: install py3 compatible cephfs and rados bindings...
on Ubuntu and CentOS for upstream testing.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit c1efd59)
ceph_volume_client: use integer division for pg_num
Otherwise a float is sent to the manager which is not the invalid format.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 3391030)
@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 27, 2018

@batrick

This comment has been minimized.

Member

batrick commented Sep 28, 2018

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

@yuriw

yuriw approved these changes Sep 28, 2018

Reviewed-by: Patrick Donnelly pdonnell@redhat.com

@yuriw yuriw merged commit f595e70 into ceph:luminous Sep 28, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@batrick batrick deleted the batrick:i26851 branch Oct 5, 2018

@smithfarm smithfarm changed the title from luminous: ceph_volume_client: py3 compatible to luminous: cephfs: ceph_volume_client: py3 compatible Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment