New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: cephfs: client: drop null child dentries before try pruning inode's alias #24119

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
4 participants
@ukernel
Member

ukernel commented Sep 17, 2018

client: drop null child dentries before try pruning inode's alias
Null child dentries holds reference on inode's alias, they prevents
Client::trim_caps() from trimming the inode. Null dentries are trimmed
by Client::trim_cache() according to 'client_cache_size' config option.
So Client::trim_caps() may fail to trim as many caps as MDS asked when
client cache size is smaller than the config limit.

Fixes: http://tracker.ceph.com/issues/22504
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit 99b1b95)

@ukernel ukernel force-pushed the ukernel:luminous-22504 branch from 70dc958 to d727b20 Sep 17, 2018

@ukernel ukernel added this to the luminous milestone Sep 17, 2018

@batrick batrick changed the title from client: drop null child dentries before try pruning inode's alias to luminous: client: drop null child dentries before try pruning inode's alias Sep 17, 2018

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Sep 27, 2018

@ukernel The idea is not to change the original commit message - i.e. not edit anything above the "(cherry picked from ...)" line.

Therefore, could you change the Fixes line back to

Fixes: http://tracker.ceph.com/issues/22293

to match the master commit 99b1b95

Thanks

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 27, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 27, 2018

@yuriw yuriw merged commit 47fc66c into ceph:luminous Sep 28, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title from luminous: client: drop null child dentries before try pruning inode's alias to luminous: cephfs: client: drop null child dentries before try pruning inode's alias Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment