New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: rbd: librbd: ensure exclusive lock acquired when removing sync point snaps… #24123

Merged
merged 2 commits into from Oct 4, 2018

Conversation

Projects
None yet
5 participants
@pdvian

pdvian commented Sep 17, 2018

@smithfarm smithfarm added this to the luminous milestone Sep 24, 2018

@smithfarm smithfarm added the rbd label Sep 24, 2018

@smithfarm smithfarm requested review from dillaman and trociny Sep 24, 2018

@trociny

LGTM

@dillaman

👍

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 27, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 27, 2018

@dillaman

This comment has been minimized.

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 28, 2018

@pdvian pls add tags when ready

@trociny

This comment has been minimized.

Contributor

trociny commented Sep 29, 2018

The problem is with luminous version of Operations::snap_remove. It passes snap_name as const char *. As a result boost::bind does not copy the snap_name string and the location of the original string is accessed after it is destroyed.

It is fixed in mimic/master with this commit 8d68fa2. Though I can't find the associated PR.

dillaman and others added some commits Jan 11, 2018

librbd: fixed memory leak and use-after-free in group snap API
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 8d68fa2)

Conflicts:
	src/librbd/api/Group.cc: removed file
librbd: ensure exclusive lock acquired when removing sync point snaps…
…hots

Fixes: http://tracker.ceph.com/issues/24898
Signed-off-by: Mykola Golub <mgolub@suse.com>
(cherry picked from commit 5bb8230)

@dillaman dillaman force-pushed the pdvian:wip-35713-luminous branch from 2f9b252 to 05070d6 Oct 1, 2018

@dillaman

This comment has been minimized.

Contributor

dillaman commented Oct 1, 2018

@pdvian I pushed the commit that @trociny highlighted to your branch and successfully re-tested valgrind locally

@yuriw

This comment has been minimized.

Contributor

yuriw commented Oct 2, 2018

@yuriw yuriw merged commit 4746c36 into ceph:luminous Oct 4, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title from luminous: librbd: ensure exclusive lock acquired when removing sync point snaps… to luminous: rbd: librbd: ensure exclusive lock acquired when removing sync point snaps… Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment