New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: core: osdc/Objecter: fix split vs reconnect race #24188

merged 1 commit into from Sep 27, 2018


None yet
6 participants

pdvian commented Sep 20, 2018

osdc/Objecter: fix split vs reconnect race
If we are reconnecting to an OSD, we may not have a connection established
so this feature check is completely unreliable.  If there happens to be a
split, that could mean we don't resend an op that should have been resent.

Instead, we can infer the OSD has the new behavior if require_osd_release
is luminous or later.  If not, we can look at the per-osd features in the

Signed-off-by: Sage Weil <>
(cherry picked from commit 917fdbe)

@tchaikov tchaikov added this to the luminous milestone Sep 20, 2018

@smithfarm smithfarm added the common label Sep 25, 2018

@smithfarm smithfarm requested review from liewegas and tchaikov Sep 25, 2018


This comment has been minimized.


yuriw commented Sep 26, 2018

@yuriw yuriw merged commit fd4647f into ceph:luminous Sep 27, 2018

4 checks passed

Docs: build check OK - docs built
Signed-off-by all commits in this PR are signed
Unmodified Submodules submodules for project are unmodified
make check make check succeeded

@smithfarm smithfarm changed the title from luminous: osdc/Objecter: fix split vs reconnect race to luminous: core: osdc/Objecter: fix split vs reconnect race Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment