New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/DaemonServer: fix Session leak #24233

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
8 participants
@liewegas
Copy link
Member

liewegas commented Sep 24, 2018

mgr/DaemonServer: fix Session leak
This bug does not exist in master.

Fixes: https://tracker.ceph.com/issues/35998
Signed-off-by: Sage Weil <sage@redhat.com>
@tomzo

This comment has been minimized.

Copy link
Contributor

tomzo commented Sep 24, 2018

I have tested exactly this change with valgrind and it fixes leak on mimic.

@tchaikov tchaikov added this to the mimic milestone Sep 26, 2018

@jcsp

This comment has been minimized.

Copy link
Contributor

jcsp commented Oct 1, 2018

@liewegas was this mimic-specific PR just because that's where the fix was being tested? Looks like we have the same issue on master.

@jcsp jcsp closed this Oct 1, 2018

@jcsp jcsp reopened this Oct 1, 2018

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 3, 2018

@jcsp The commit message says: "This bug does not exist in master." Are you saying that statement is false?

@jcsp

This comment has been minimized.

Copy link
Contributor

jcsp commented Oct 3, 2018

@smithfarm oops, in this case I'm just failing to read commit messages :-)

Never mind!

@jcsp

This comment has been minimized.

Copy link
Contributor

jcsp commented Oct 3, 2018

When I suggested we had the same issue on master it was just that the same LOC was unchanged there, I'm guessing that Sage already checked through and the reference counting was correct in master

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 3, 2018

@yuriw yuriw merged commit 5f3df0d into ceph:mimic Oct 5, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@gucki

This comment has been minimized.

Copy link
Member

gucki commented Oct 17, 2018

Could this please released soon? Some of my msgr daemons eat several GB of ram within a few days and they always need to be restarted periodically....

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 17, 2018

@gucki Barring unforeseen circumstances, mimic 13.2.3 will be released soon, yes.

@tomzo

This comment has been minimized.

Copy link
Contributor

tomzo commented Oct 17, 2018

@gucki can you have a look at https://tracker.ceph.com/issues/36471 and see if maybe you have similar problems as I do? I am a bit confused if there is still a problem in ceph or is it my deployment only.

@liewegas liewegas deleted the liewegas:wip-35998-mimic branch Oct 17, 2018

@gucki

This comment has been minimized.

Copy link
Member

gucki commented Dec 13, 2018

@smithfarm I'm sorry, but what's the definition of soon? According to the release schedule a point release is done every 4-6 weeks. However the last release was done in 09/18 so at least 10 weeks ago... :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment