New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: multisite: segfault on shutdown/realm reload #24235

Merged
merged 3 commits into from Oct 17, 2018

Conversation

Projects
None yet
5 participants
@pdvian
Copy link

pdvian commented Sep 24, 2018

cbodley added some commits Sep 4, 2018

rgw: RGWAsyncGetSystemObj does not access coroutine memory
now reads the buffer/attrs into local memory, and calling coroutines
copy out the result during request_complete()

Fixes: http://tracker.ceph.com/issues/35543

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 089db9f)

Conflicts:
	src/rgw/rgw_cr_rados.h : Resolved in request_complete
rgw: RGWAsyncPutSystemObj does not access coroutine memory
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 8539667)
rgw: RGWAsyncPutSystemObjAttrs does not access coroutine memory
also exposes optional objv_tracker to RGWSimpleRadosWriteAttrsCR

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit b01b395)
@@ -248,7 +239,7 @@ int RGWSimpleRadosReadCR<T>::request_complete()
return ret;
}
try {
bufferlist::iterator iter = bl.begin();
bufferlist::iterator iter = req->bl.begin();

This comment has been minimized.

@pdvian

@smithfarm smithfarm added this to the mimic milestone Sep 25, 2018

@smithfarm smithfarm added the rgw label Sep 25, 2018

@smithfarm smithfarm added the needs-qa label Oct 4, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 15, 2018

@yuriw yuriw merged commit 684e267 into ceph:mimic Oct 17, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment