New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rpm: use updated gperftools #24260

Merged
merged 2 commits into from Oct 29, 2018

Conversation

@tchaikov
Copy link
Contributor

tchaikov commented Sep 25, 2018

https://tracker.ceph.com/issues/36132
https://tracker.ceph.com/issues/36553


make sure we only build with the higher version of gperftools on
distros where both 2.4 and 2.6.1 are packaged. see
https://git.centos.org/summary/rpms!gperftools.git . at the time of
writing, gperftools 2.6.1 is packaged for CentOS/RHEL 7, if gperftools
(>= 2.4) is required by Ceph, and user already has this version
installed, when new Ceph packages are installed, the updated gperftools
2.6.1 version won't be installed as a dependency. when launching
Ceph compiled with tcmalloc enabled, we will have

symbol lookup error: ceph-osd: undefined symbol: _ZdaPvm

so, by bumping up the required version of gperftools, the updated
gperftools will be installed.

see https://software.opensuse.org/package/gperftools, openSUSE/SLE offer
2.5. so they are safe at this moment.

Fixes: http://tracker.ceph.com/issues/35969
Signed-off-by: Kefu Chai kchai@redhat.com
(cherry picked from commit e69e50a)

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

@tchaikov tchaikov added this to the mimic milestone Sep 25, 2018

@tchaikov tchaikov requested review from badone and smithfarm Sep 25, 2018

@smithfarm smithfarm added the build/ops label Sep 25, 2018

@badone

badone approved these changes Sep 26, 2018

Copy link
Contributor

badone left a comment

LGTM

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 3, 2018

@badone

This comment has been minimized.

Copy link
Contributor

badone commented Oct 11, 2018

Looking into this.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Oct 18, 2018

#24652 will address this.

@smithfarm
Copy link
Contributor

smithfarm left a comment

Please cherry-pick https://tracker.ceph.com/issues/36553 into this PR?

tchaikov and others added some commits Sep 17, 2018

rpm: use updated gperftools
make sure we only build with the higher version of gperftools on
distros where both 2.4 and 2.6.1 are packaged. see
https://git.centos.org/summary/rpms!gperftools.git . at the time of
writing, gperftools 2.6.1 is packaged for CentOS/RHEL 7, if gperftools
(>= 2.4) is required by Ceph, and user already has this version
installed, when new Ceph packages are installed, the updated gperftools
2.6.1 version won't be installed as a dependency. when launching
Ceph compiled with tcmalloc enabled, we will have

symbol lookup error: ceph-osd: undefined symbol: _ZdaPvm

so, by bumping up the required version of gperftools, the updated
gperftools will be installed.

see https://software.opensuse.org/package/gperftools, openSUSE/SLE offer
2.5. so they are safe at this moment.

Fixes: http://tracker.ceph.com/issues/35969
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit e69e50a)
rpm: Use updated gperftools-libs at runtime
Due to ABI breakage in libtcmalloc.so.4 we need to specify the minimum
version to be used at runtime to be greater than or equal to the version
used at build time.

Fixes: http://tracker.ceph.com/issues/36508

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit 2463626)

@tchaikov tchaikov force-pushed the tchaikov:mimic-35969 branch from 9912456 to 52bae57 Oct 23, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Oct 23, 2018

@smithfarm done.

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 23, 2018

@yuriw yuriw merged commit 32b7130 into ceph:mimic Oct 29, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:mimic-35969 branch Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment