New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: ceph-volume: custom cluster names fail on filestore trigger #24280

Merged
merged 10 commits into from Sep 27, 2018

Conversation

Projects
None yet
3 participants
@alfredodeza
Contributor

alfredodeza commented Sep 25, 2018

This happens because the ceph.conf is not loaded by main.py, and later the code wants to poke in conf.ceph which is a bare property that doesn't have anything
in it.

The activate script should be aware of the custom cluster name by that time, and it should try to load the conf file. It should also try to fallback if that is
not able to be located, so that default flags for mounting don't end up preventing an OSD starting up

This PR also updates all the functional tests to use test as a cluster name.

Fixes: http://tracker.ceph.com/issues/27210
Backport of: #24251

alfredodeza added some commits Sep 19, 2018

ceph-volume configuration be able to set conf.ceph
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 4f8226f)
ceph-volume lvm.activate load the config always by reading the cluste…
…r name from the LV

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit a88cbfc)
ceph-volume tests.functional add custom cluster name to centos7-files…
…tore-create

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit e61848d)
ceph-volume tests reset the cluster name after every unit test
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 877ee1a)
ceph-volume tests.devices patch configuration.load to avoid raising n…
…on-existing ceph.conf

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit fe80e53)
ceph-volume main move out the load_ceph_conf_path to the configuratio…
…n module

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 5329080)
ceph-volume tests/functional update playbooks to use --cluster
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit ba10b68)
ceph-volume tests/functional/lvm update tests to use 'test' cluster name
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 7b0d2dc)
ceph-volume tests/functional/batch update tests to use 'test' cluster…
… name

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 5f72d43)
ceph-volume tests/functional update dmcrypt test playbooks to use --c…
…luster

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 96e29ad)

@ceph-jenkins ceph-jenkins added this to the luminous milestone Sep 25, 2018

@alfredodeza alfredodeza requested a review from andrewschoen Sep 25, 2018

@andrewschoen andrewschoen merged commit 3b8fc88 into ceph:luminous Sep 27, 2018

37 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume batch testing centos7-bluestore-mixed_type OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-bluestore-single_type OK
Details
ceph-volume batch testing centos7-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-single_type OK
Details
ceph-volume batch testing centos7-filestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-bluestore-single_type OK
Details
ceph-volume batch testing xenial-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-filestore-single_type OK
Details
ceph-volume batch testing xenial-filestore-single_type_dmcrypt OK
Details
ceph-volume lvm testing centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-create OK
Details
ceph-volume lvm testing centos7-filestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-bluestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-create OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt OK
Details
ceph-volume simple testing centos7-bluestore-activate OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing centos7-filestore-activate OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-bluestore-activate OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-filestore-activate OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_plain OK
Details
ceph-volume tox tests OK
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title from luminous ceph-volume custom cluster names fail on filestore trigger to luminous: ceph-volume custom cluster names fail on filestore trigger Oct 26, 2018

@smithfarm smithfarm changed the title from luminous: ceph-volume custom cluster names fail on filestore trigger to luminous: ceph-volume: custom cluster names fail on filestore trigger Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment