New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: ceph-volume: fix journal and filestore data size in `lvm batch --report` #24307

Merged
merged 3 commits into from Sep 27, 2018

Conversation

Projects
None yet
3 participants
@alfredodeza
Contributor

alfredodeza commented Sep 27, 2018

When running ceph-volume lvm batch --report --filestore $devices the journal size and data size were being reported as the __repr__ of the size class (e.g. "size": <FloatB(7516192768.0)>). This was causing JSON parsing issues as well as not being friendly to the reader of the report.

This also includes some testing changes that make our functional tests fail fast and saves some time by only running the ceph-common role from ceph-ansible once during testing.

Fixes: http://tracker.ceph.com/issues/36242
Backport of: #24274

andrewschoen added some commits Sep 24, 2018

ceph-volume: when using batch --report return journal/data size as ints
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit a5e8bc9)
ceph-volume: fail fast during tests
This also rsyncs the ceph-volume code to the testing vms before
a ceph.conf is generated because ceph-volume is needed now for this
to figure out the number of osds when you're using 'lvm batch'.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit eed2444)
ceph-volume: only run ceph-common once during tests
Using import_role we can have just one play and avoid rerunning
ceph-common over and over again in daemon specific plays.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit a813861)

@ceph-jenkins ceph-jenkins added this to the luminous milestone Sep 27, 2018

@alfredodeza alfredodeza requested a review from andrewschoen Sep 27, 2018

@andrewschoen andrewschoen merged commit cc4fc3c into ceph:luminous Sep 27, 2018

36 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume batch testing centos7-bluestore-mixed_type OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-bluestore-single_type OK
Details
ceph-volume batch testing centos7-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-single_type OK
Details
ceph-volume batch testing centos7-filestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-bluestore-single_type OK
Details
ceph-volume batch testing xenial-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-filestore-single_type_dmcrypt OK
Details
ceph-volume lvm testing centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-create OK
Details
ceph-volume lvm testing centos7-filestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-bluestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-create OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt OK
Details
ceph-volume simple testing centos7-bluestore-activate OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing centos7-filestore-activate OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-bluestore-activate OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-filestore-activate OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_plain OK
Details
ceph-volume tox tests OK
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title from luminous ceph-volume: fix journal and filestore data size in `lvm batch --report` to luminous: ceph-volume: fix journal and filestore data size in `lvm batch --report` Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment