New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: osd: PrimaryLogPG: fix potential pg-log overtrimming #24308

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
4 participants
@neha-ojha
Member

neha-ojha commented Sep 27, 2018

https://tracker.ceph.com/issues/36274


This is a backport of #23317

https://tracker.ceph.com/issues/36239

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
osd/PrimaryLogPG: fix potential pg-log overtrimming
In #21580 I set a trap to catch some wired
and random segmentfaults and in a recent QA run I was able to observe it was
successfully triggered by one of the test case, see:

```
http://qa-proxy.ceph.com/teuthology/xxg-2018-07-30_05:25:06-rados-wip-hb-peers-distro-basic-smithi/2837916/teuthology.log
```

The root cause is that there might be holes on log versions, thus the
approx_size() method should (almost) always overestimate the actual number of log entries.
As a result, we might be at the risk of overtrimming log entries.

#18338 reveals a probably easier way
to fix the above problem but unfortunately it also can cause big performance regression
and hence comes this pr..

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
(cherry picked from commit 3654d56)

Conflicts:
	src/osd/PrimaryLogPG.cc: trivial resolution

@neha-ojha neha-ojha added the needs-qa label Sep 28, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 28, 2018

@yuriw yuriw merged commit 5b56b60 into ceph:luminous Oct 1, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title from luminous: osd/PrimaryLogPG: fix potential pg-log overtrimming to luminous: osd: PrimaryLogPG: fix potential pg-log overtrimming Oct 26, 2018

yuriw added a commit to yuriw/ceph that referenced this pull request Nov 5, 2018

qa/tests - added pg log settings
Fixes: ceph#24308
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

yuriw added a commit to yuriw/ceph that referenced this pull request Nov 5, 2018

qa/tests - added pg log settings
Fixes: ceph#24308
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

yuriw added a commit to yuriw/ceph that referenced this pull request Nov 5, 2018

qa/tests - added pg log settings to luminous-x, rados/upgrade
Fixes: ceph#24308
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

yuriw added a commit to yuriw/ceph that referenced this pull request Nov 6, 2018

qa/tests - added pg log settings to luminous-x, rados/upgrade
Fixes: ceph#24308
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

yuriw added a commit to yuriw/ceph that referenced this pull request Nov 6, 2018

qa/tests: added pg log settings to luminous-x
Fixes: ceph#24308
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

yuriw added a commit to yuriw/ceph that referenced this pull request Nov 6, 2018

qa/tests: added pg log settings to luminous-x
Fixes: ceph#24308
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

yuriw added a commit to yuriw/ceph that referenced this pull request Nov 6, 2018

qa/tests: added pg log settings to mimic-x
Fixes: ceph#24308
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

@yuriw yuriw referenced this pull request Nov 6, 2018

Open

qa/tests: added pg log settings to mimic-x #24954

0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment