New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: mds: runs out of file descriptors after several respawns #24310

Merged
merged 2 commits into from Oct 1, 2018

Conversation

Projects
None yet
3 participants
@batrick
Member

batrick commented Sep 27, 2018

msg: set O_NONBLOCK on file status flags
There is no NONBLOCK file **descriptor** flag.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 7e91c8b)

Conflicts:
	src/msg/simple/Accepter.cc

@batrick batrick added this to the luminous milestone Sep 27, 2018

@batrick batrick changed the base branch from master to luminous Sep 27, 2018

@batrick batrick force-pushed the batrick:i36210 branch from 9ebcf2f to 646600f Sep 27, 2018

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Sep 28, 2018

/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/simple/Accepter.cc: In member function ‘int Accepter::create_selfpipe(int*, int*)’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/simple/Accepter.cc:52:26: error: ‘size’ is not a member of ‘std’
   for (size_t i = 0; i < std::size(selfpipe); i++) {
                          ^

@batrick batrick force-pushed the batrick:i36210 branch from 646600f to 4cfd880 Sep 28, 2018

*: set missing CLOEXEC on opened fds
Otherwise these descriptors may leak across execve() during e.g. MDS respawn.

Fixes: http://tracker.ceph.com/issues/35850

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 86dbd9e)

Conflicts:
	CMakeLists.txt
	src/auth/Crypto.cc
	src/ceph_osd.cc
	src/common/CMakeLists.txt
	src/common/Preforker.h
	src/common/SubProcess.cc
	src/common/admin_socket.cc
	src/common/admin_socket_client.cc
	src/common/blkdev.cc
	src/crimson/CMakeLists.txt
	src/global/signal_handler.cc
	src/include/random.h
	src/include/uuid.h
	src/log/Log.cc
	src/mon/MonitorDBStore.h
	src/msg/simple/Accepter.cc
	src/os/bluestore/BlueStore.cc
	src/os/bluestore/bluestore_tool.cc
	src/os/filestore/FileStore.cc
	src/os/kstore/KStore.cc
	src/test/objectstore/test_bluefs.cc
@yuriw

This comment has been minimized.

Contributor

yuriw commented Sep 28, 2018

@batrick

This comment has been minimized.

Member

batrick commented Oct 1, 2018

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

@yuriw

yuriw approved these changes Oct 1, 2018

Reviewed-by: Patrick Donnelly pdonnell@redhat.com

@yuriw yuriw merged commit db466bc into ceph:luminous Oct 1, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@batrick batrick deleted the batrick:i36210 branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment