New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: ceph-volume: lsblk can fail to find PARTLABEL, must fallback to blkid #24335

Merged
merged 6 commits into from Oct 1, 2018

Conversation

Projects
None yet
3 participants
@alfredodeza
Contributor

alfredodeza commented Sep 28, 2018

Specifically in containers, PARTLABEL might not come back with any value at all, while blkid will. This PR also introduces an API for ceph-disk devices which will allow better interaction with legacy OSDs.

Fixes: http://tracker.ceph.com/issues/36098
Backport of: #24330

@ceph-jenkins ceph-jenkins added this to the luminous milestone Sep 28, 2018

alfredodeza added some commits Sep 25, 2018

ceph-volume util.disk expand blkid's API calls
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit dbde6a5)
ceph-volume tests.util verify new blkid API calls
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit ead3c7e)
ceph-volume util.device add a ceph-disk device object to detect types
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 200e6bf)
ceph-volume tests.conftest add blkid patching to device_info fixture
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 5bfc8c2)
ceph-volume tests.util verify CephDiskDevice behavior
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 8f072eb)
ceph-volume simple.scan better detection for ceph-disk data devices
Uses the new ``CephDiskDevice`` to look into PARTLABEL from both lsblk
(the default) falling back to blkid, which in some cases has the right
value when lsblk fails.

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit c502e5f)

@alfredodeza alfredodeza force-pushed the alfredodeza:luminous-rm36098 branch from cd11d54 to ffa1649 Sep 28, 2018

@alfredodeza alfredodeza requested a review from andrewschoen Oct 1, 2018

@andrewschoen andrewschoen merged commit 5c76018 into ceph:luminous Oct 1, 2018

24 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume batch testing centos7-bluestore-mixed_type OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-bluestore-single_type OK
Details
ceph-volume batch testing centos7-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-single_type OK
Details
ceph-volume batch testing centos7-filestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-bluestore-single_type OK
Details
ceph-volume batch testing xenial-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-filestore-single_type OK
Details
ceph-volume batch testing xenial-filestore-single_type_dmcrypt OK
Details
ceph-volume lvm testing centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-create OK
Details
ceph-volume lvm testing centos7-filestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-bluestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-create OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt OK
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title from luminous ceph-volume: lsblk can fail to find PARTLABEL, must fallback to blkid to luminous: ceph-volume: lsblk can fail to find PARTLABEL, must fallback to blkid Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment