New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: core: ceph-disk: compatibility fix for python 3 #24347

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
4 participants
@pdvian

pdvian commented Oct 1, 2018

ceph-disk: compatibility fix for python 3
In python 3, dev is a string, but mounts_dev is bytes (because
/proc/mounts was opened with mode 'rb') so they can't compare
equal, resulting in is_mounted() returning None for mounted OSDs.
The safest fix for this we could come up with was to normalize
dev to a str using _bytes2str() (just in case), and open
/proc/mounts in mode 'r', so its lines are interpreted as strs.

Fixes: https://tracker.ceph.com/issues/35906
Signed-off-by: Tim Serong <tserong@suse.com>
(cherry picked from commit 8e3d948)

@smithfarm smithfarm added this to the luminous milestone Oct 1, 2018

@smithfarm smithfarm changed the title from luminous:ceph-disk: compatibility fix for python 3 to luminous: ceph-disk: compatibility fix for python 3 Oct 1, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Oct 1, 2018

@yuriw yuriw requested a review from smithfarm Oct 2, 2018

@yuriw yuriw merged commit f394dfb into ceph:luminous Oct 2, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title from luminous: ceph-disk: compatibility fix for python 3 to luminous: core: ceph-disk: compatibility fix for python 3 Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment