New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ceph-bluestore-tool: fix set label functionality for specific keys #24352

Merged
merged 3 commits into from Oct 5, 2018

Conversation

Projects
None yet
5 participants
@ifed01
Copy link
Contributor

ifed01 commented Oct 1, 2018

'size' and some other labels (which are direct bluestore_bdev_label_t struct members) weren't updated properly.
Also automatically apply size label update on bluefs-bdev-expand command to be more user friendly.

It appears we might need this functionality in mimic to be able to manually recover from
https://tracker.ceph.com/issues/36268

Not fixes this ticket though.
Signed-off-by: Igor Fedotov ifedotov@suse.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

ifed01 added some commits May 18, 2018

tool/ceph-bluestore-tool: avoid mon/config access when calling global…
…_init

This caused a permanent stuck on tool's startup.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit fa65e7b)
tools/ceph-bluestore-tool: add support for proper setting size, btime,
description, osd_uuid fields

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit ffac450)
tools/ceph-bluestore-tool: update size label on bluefs expand
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit 71c3b58)

@tchaikov tchaikov added this to the mimic milestone Oct 2, 2018

@smithfarm smithfarm requested review from liewegas , tchaikov and xiexingguo Oct 3, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 3, 2018

@yuriw yuriw merged commit 41ec03c into ceph:mimic Oct 5, 2018

4 of 5 checks passed

make check (arm64) Build triggered for original commit.
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment