New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: ceph-volume: activate option --auto-detect-objectstore respects --no-systemd #24358

Merged
merged 2 commits into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@alfredodeza
Contributor

alfredodeza commented Oct 1, 2018

The --auto-detect-objectstore flag was meant to make it easier for systemd to load/activate OSDs, which is why it was omitted when the --no-systemd flag was added. This PR fixes that omission and adds a few tests to ensure its new optional behavior.

Fixes: http://tracker.ceph.com/issues/36249
Backport of: #24355

@ceph-jenkins ceph-jenkins added this to the luminous milestone Oct 1, 2018

alfredodeza added some commits Oct 1, 2018

ceph-volume tests.lvm verify activate works with --auto-detect-object…
…store

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 60dbeb6)
ceph-volume lvm.activate pass no_systemd args when detecting objectstore
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 29de682)

@alfredodeza alfredodeza requested a review from andrewschoen Oct 2, 2018

@andrewschoen andrewschoen merged commit e4c6e72 into ceph:luminous Oct 2, 2018

25 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume batch testing centos7-bluestore-mixed_type OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-bluestore-single_type OK
Details
ceph-volume batch testing centos7-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-single_type OK
Details
ceph-volume batch testing centos7-filestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-bluestore-single_type OK
Details
ceph-volume batch testing xenial-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-filestore-single_type OK
Details
ceph-volume batch testing xenial-filestore-single_type_dmcrypt OK
Details
ceph-volume lvm testing centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-create OK
Details
ceph-volume lvm testing centos7-filestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-bluestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-create OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt OK
Details
ceph-volume tox tests OK
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title from luminous ceph-volume: activate option --auto-detect-objectstore respects --no-systemd to luminous: ceph-volume: activate option --auto-detect-objectstore respects --no-systemd Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment