New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: msg/async: clean up local buffers on dispatch #24386

merged 1 commit into from Oct 5, 2018


None yet
6 participants
Copy link

pdvian commented Oct 2, 2018

msg/async: clean up local buffers on dispatch
The AsyncConnection keeps local (member variable) bufferlists of incoming
messages before they're placed into the Message's front/data/middle buffers.
Previously these were reset only when a new Message is being received, which
means in steady state we store a full Message for every Connection even if
it's inactive!

Instead we obviously want to drop our local references to Message state
once it's been dispatched, so that it can go away.


Signed-off-by: Greg Farnum <>
(cherry picked from commit 47ed036)

@smithfarm smithfarm added this to the mimic milestone Oct 3, 2018

@smithfarm smithfarm added the core label Oct 3, 2018

@smithfarm smithfarm requested review from gregsfortytwo , rjfd and tchaikov Oct 3, 2018


rjfd approved these changes Oct 3, 2018

Copy link

rjfd left a comment



This comment has been minimized.

Copy link

yuriw commented Oct 3, 2018

@yuriw yuriw merged commit b6fee4e into ceph:mimic Oct 5, 2018

4 checks passed

Docs: build check OK - docs built
Signed-off-by all commits in this PR are signed
Unmodified Submodules submodules for project are unmodified
make check make check succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment