New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: msg: async: clean up local buffers on dispatch #24387

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
6 participants
@pdvian

pdvian commented Oct 2, 2018

msg/async: clean up local buffers on dispatch
The AsyncConnection keeps local (member variable) bufferlists of incoming
messages before they're placed into the Message's front/data/middle buffers.
Previously these were reset only when a new Message is being received, which
means in steady state we store a full Message for every Connection even if
it's inactive!

Instead we obviously want to drop our local references to Message state
once it's been dispatched, so that it can go away.

Fixes: http://tracker.ceph.com/issues/35987

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
(cherry picked from commit 47ed036)

@smithfarm smithfarm added this to the luminous milestone Oct 3, 2018

@smithfarm smithfarm requested review from rjfd, gregsfortytwo and tchaikov Oct 3, 2018

@rjfd

rjfd approved these changes Oct 3, 2018

lgtm

@yuriw

This comment has been minimized.

Contributor

yuriw commented Oct 3, 2018

@yuriw yuriw merged commit d652f4e into ceph:luminous Oct 4, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title from luminous: msg/async: clean up local buffers on dispatch to luminous: msg: async: clean up local buffers on dispatch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment