New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: mon: Automatically set expected_num_objects for new pools with >=100 PGs per OSD #24395

Merged
merged 2 commits into from Oct 4, 2018

Conversation

@smithfarm
Contributor

smithfarm commented Oct 3, 2018

fullerdj added some commits Jun 28, 2018

mon/OSDMonitor: Warn when expected_num_objects will have no effect
The expected_num_objects argument to ceph osd pool create is
only effective on filestore pools when merging is disabled
(filestore_merge_threshold < 0). Warn and disallow pool creation
in this situation.

Signed-off-by: Douglas Fuller <dfuller@redhat.com>
(cherry picked from commit 4c108a5)
mon/OSDMonitor: Warn if missing expected_num_objects
When creating a pool on filestore, warn if the user appears to be
creating a pool to store a large number of objects but omitted the
expected_num_objects parameter. Create the pool anyway.

Fixes: http://tracker.ceph.com/issues/24687
Signed-off-by: Douglas Fuller <dfuller@redhat.com>
(cherry picked from commit 69fb229)

@smithfarm smithfarm self-assigned this Oct 3, 2018

@smithfarm smithfarm added this to the luminous milestone Oct 3, 2018

@smithfarm smithfarm requested review from jdurgin and neha-ojha Oct 3, 2018

@smithfarm smithfarm changed the title from luminous: Automatically set expected_num_objects for new pools with >=100 PGs per OSD to luminous: mon: Automatically set expected_num_objects for new pools with >=100 PGs per OSD Oct 3, 2018

@yuriw

This comment has been minimized.

Contributor

yuriw commented Oct 3, 2018

@yuriw yuriw merged commit 31d3381 into ceph:luminous Oct 4, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-25145-luminous branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment