New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: qa: fsstress workunit does not execute in parallel on same host without clobbering files #24408

Merged
merged 7 commits into from Oct 19, 2018

Conversation

Projects
None yet
3 participants

batrick added some commits Sep 18, 2018

qa: cleanup parallel execution of fsstress
Two instances of fsstress clobber each other. Just build it in the local sandbox.

Fixes: http://tracker.ceph.com/issues/24177

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit de824f7)
qa: use sudo to cleanup workspace
Files in scratch_tmp may not be owned by ubuntu.

Fixes: http://tracker.ceph.com/issues/36165
Introduced-by: de824f7
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 1eaf78a)

@smithfarm smithfarm self-assigned this Oct 3, 2018

@smithfarm smithfarm added this to the mimic milestone Oct 3, 2018

@smithfarm smithfarm added bug fix core cephfs tests and removed core labels Oct 3, 2018

@smithfarm smithfarm requested a review from batrick Oct 3, 2018

batrick added some commits Sep 26, 2018

qa: do not cleanup sandbox on error
Otherwise the command will hang if the mount is broken.

Fixes: http://tracker.ceph.com/issues/36184
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit d4b8f94)
qa: use default timeout in fs workunits
Six hours is unnecessarily long.

Fixes: http://tracker.ceph.com/issues/36184
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit bdd2ddc)
qa: add timeout to kclient umount
Otherwise QA sits forever waiting for the kclient to umount when there is a
problem.

Fixes: http://tracker.ceph.com/issues/36184
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 7a64eb9)
qa: cleanup workunit dir for each unit
This was wrongly dropped and moved to the finalizer.

Introduced-by: de824f7
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 70844f3)
qa: add timeout to cleaning up workunit sandbox
If there is a bug preventing rm from completing, the workunit will get stuck.

Fixes: http://tracker.ceph.com/issues/36184
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 3a10d74)
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 5, 2018

@batrick Brought in the follow-up fixes. Ready for review?

@batrick

This comment has been minimized.

Copy link
Member

batrick commented Oct 6, 2018

LGTM

@batrick

This comment has been minimized.

Copy link
Member

batrick commented Oct 9, 2018

Will also need fix for http://tracker.ceph.com/issues/36365

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 15, 2018

@yuriw yuriw merged commit a4cd96c into ceph:mimic Oct 19, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-36153-mimic branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment