New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: osd: OSDMapMapping does not handle active.size() > pool size #24431

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@smithfarm
Copy link
Contributor

smithfarm commented Oct 4, 2018

@smithfarm smithfarm self-assigned this Oct 4, 2018

@smithfarm smithfarm added this to the mimic milestone Oct 4, 2018

@smithfarm smithfarm requested review from liewegas and gregsfortytwo Oct 4, 2018

osd/OSDMap: clean out pg_temp mappings that exceed pool size
If the pool size is reduced, we can end up with pg_temp mappings that are
too big.  This can trigger bad behavior elsewhere (e.g., OSDMapMapping,
which assumes that acting and up are always <= pool size).

Fixes: http://tracker.ceph.com/issues/26866
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit daf53f4)

Conflicts:
	src/osd/OSDMap.cc

@smithfarm smithfarm force-pushed the smithfarm:wip-35936-mimic branch from 6cc6782 to 6b8d23d Oct 4, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 23, 2018

@yuriw yuriw merged commit 5824895 into ceph:mimic Oct 29, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm changed the title mimic: OSDMapMapping does not handle active.size() > pool size mimic: osd: OSDMapMapping does not handle active.size() > pool size Oct 29, 2018

@smithfarm smithfarm deleted the smithfarm:wip-35936-mimic branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment