New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw/beast: drop privileges after binding ports #24436

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
4 participants
@emmericp
Copy link
Contributor

emmericp commented Oct 4, 2018

https://tracker.ceph.com/issues/36332


I've also included cbodley@8e0d0f3 in this backport despite not being merged into master yet, is that okay?

rgw/beast: drop privileges after binding ports
Fixes: http://tracker.ceph.com/issues/36041

Signed-off-by: Paul Emmerich <paul.emmerich@croit.io>
(cherry picked from commit 6489566)

 Conflicts:
	src/rgw/rgw_asio_frontend.cc

@emmericp emmericp changed the title rgw/beast: drop privileges after binding ports mimic: rgw/beast: drop privileges after binding ports Oct 4, 2018

@emmericp

This comment has been minimized.

Copy link
Contributor

emmericp commented Oct 4, 2018

I'll also do it for luminous after you let me know if this looks okay with the tests. We are eager to get that fixed upstream sooner than later because this avoids some ugly code on our side (and we don't want to diverge too much on our builds)

@cbodley

This comment has been minimized.

Copy link
Contributor

cbodley commented Oct 5, 2018

I've also included cbodley@8e0d0f3 in this backport despite not being merged into master yet, is that okay?

good question. that commit was necessary to validate the fix, but i didn't propose merging it because i'm not sure we want to test privileged ports exclusively. i'll bring it up in the rgw standup today and see what others think

@cbodley cbodley added this to the mimic milestone Oct 5, 2018

@cbodley

This comment has been minimized.

Copy link
Contributor

cbodley commented Oct 5, 2018

@emmericp lets just drop that test commit for now. if we decide to follow up on it later, we would merge it to master and backport it separately. sound okay?

@emmericp emmericp force-pushed the croit:mimic-36041 branch from 5fa2819 to 4b5859d Oct 5, 2018

@emmericp

This comment has been minimized.

Copy link
Contributor

emmericp commented Oct 5, 2018

done

@smithfarm smithfarm requested a review from cbodley Oct 6, 2018

@cbodley

cbodley approved these changes Oct 8, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 12, 2018

@yuriw yuriw merged commit b957a53 into ceph:mimic Oct 15, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment