New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: cephfs: ceph_volume_client: py3 compatible #24443

Merged
merged 7 commits into from Nov 1, 2018

Conversation

Projects
None yet
5 participants
@smithfarm
Copy link
Contributor

smithfarm commented Oct 5, 2018

rishabh-d-dave and others added some commits May 15, 2018

ceph-volume-client: add py3 compatibility
Fixes: http://tracker.ceph.com/issues/17230
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit efdf1af)
cephfs.pyx: add py3 compatibility
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 5106582)
qa: make test_volume_client.py py3 compatible
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit f28274d)
qa: test py2 and py3 for volume client
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit a5e3b05)
packages.yaml: install py3 compatible cephfs and rados bindings...
on Ubuntu and CentOS for upstream testing.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit c1efd59)
qa/ceph-volume: allow executing python pyloads using python3
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 2f35ade)

Conflicts:
	qa/tasks/vstart_runner.py
- mimic version of preceding mount() method does not end in
  "self.gather_mount_info()" like it does in master
ceph_volume_client: use integer division for pg_num
Otherwise a float is sent to the manager which is not the invalid format.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 3391030)
@neha-ojha

This comment has been minimized.

Copy link
Member

neha-ojha commented Oct 9, 2018

@yuriw @batrick Let's run the rados:upgrade suite on this PR, in order to test if we need #24479 for mimic.

@batrick batrick added the cephfs label Oct 10, 2018

@smithfarm smithfarm added the needs-qa label Oct 23, 2018

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 23, 2018

@yuriw Please run rados:upgrade as requested by @neha-ojha, above.

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 30, 2018

@batrick

batrick approved these changes Nov 1, 2018

@yuriw yuriw merged commit 1c37b62 into ceph:mimic Nov 1, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-26850-mimic branch Nov 3, 2018

@smithfarm smithfarm changed the title mimic: ceph_volume_client: py3 compatible mimic: cephfs: ceph_volume_client: py3 compatible Nov 3, 2018

@neha-ojha

This comment has been minimized.

Copy link
Member

neha-ojha commented Nov 19, 2018

@batrick

This comment has been minimized.

Copy link
Member

batrick commented Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment