New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic:mds: fix mds damaged due to unexpected journal length #24463

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
None yet
6 participants
@pdvian
Copy link

pdvian commented Oct 8, 2018

Zhi Zhang Prashant D
mds: fix mds damaged due to unexpected journal length
We used first next_safe_pos in pending_safe to update journal's safe_pos, but
it might not be flushed at this time, so journal's header may get incorrect
write_pos in some case, which could cause mds damaged.

This fix is trying to use current min next_safe_pos in pending_safe to update
journal's safe_pos.

Signed-off-by: Zhi Zhang <zhangz.david@outlook.com>
(cherry picked from commit d17790f)

Conflicts:
	src/osdc/Journaler.cc : Resolved in _finish_flush

@tchaikov tchaikov added this to the mimic milestone Oct 8, 2018

@ukernel

This comment has been minimized.

Copy link
Member

ukernel commented Oct 8, 2018

LGTM

@ukernel

ukernel approved these changes Oct 8, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 15, 2018

@yuriw yuriw merged commit 7092334 into ceph:mimic Oct 19, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment