New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mds: curate priority of perf counters sent to mgr #24467

Merged
merged 10 commits into from Nov 12, 2018

Conversation

Projects
None yet
4 participants
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 8, 2018

@vshankar It looks like https://tracker.ceph.com/issues/35938 depends on this. Could you cherry-pick those two commits into this PR and add https://tracker.ceph.com/issues/35938 to the PR description?

@vshankar

This comment has been minimized.

Copy link
Contributor

vshankar commented Oct 8, 2018

@vshankar It looks like https://tracker.ceph.com/issues/35938 depends on this. Could you cherry-pick those two commits into this PR and add https://tracker.ceph.com/issues/35938 to the PR description?

ack --- will update the pr in a while...

@vshankar

This comment has been minimized.

Copy link
Contributor

vshankar commented Oct 10, 2018

I think #23635 should be backported before attempting to backport https://tracker.ceph.com/issues/35938

@batrick ?

@smithfarm smithfarm added this to the mimic milestone Oct 10, 2018

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 10, 2018

@vshankar The mimic backport issue for #23635 is http://tracker.ceph.com/issues/35837 and it's open - you can do that backport in this PR as well, if you like.

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 10, 2018

(Just please make sure all relevant backport tracker issues are in the PR description)

@vshankar

This comment has been minimized.

Copy link
Contributor

vshankar commented Oct 10, 2018

@smithfarm thanks -- I think it would be wise to include that too...

@batrick

This comment has been minimized.

Copy link
Member

batrick commented Oct 10, 2018

Doing all three backports in this PR works for me.

@vshankar vshankar force-pushed the vshankar:wip-26991 branch from f46ecef to fdb110d Oct 11, 2018

@vshankar

This comment has been minimized.

Copy link
Contributor

vshankar commented Oct 11, 2018

update pr and tracker description

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 23, 2018

@vshankar Needs rebase.

@vshankar vshankar force-pushed the vshankar:wip-26991 branch from fdb110d to a45cfb7 Oct 24, 2018

@vshankar vshankar removed the needs-rebase label Oct 25, 2018

@vshankar

This comment has been minimized.

Copy link
Contributor

vshankar commented Oct 25, 2018

rebased and updated

@batrick

This comment has been minimized.

Copy link
Member

batrick commented Oct 30, 2018

Needs another rebase.

vshankar and others added some commits Jun 22, 2018

mds: reorganize and curate perf log counters
Categorize perf counters into high (PRIO_{CRITICAL/INTERESTING}),
medium (PRIO_USEFUL) and low priority (PRIO_DEBUGONLY). High and
medium priority stats are transmitted to ceph mgr and included in
prometheus output.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
Fixes: http://tracker.ceph.com/issues/26991
(cherry picked from commit 48a33f6)

 Conflicts:
	src/mds/Server.cc
mds: add perf counters to track current open/stale sessions
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 315aa47)
mds: decay counter for tracking request load average
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 816d8aa)

 Conflicts:
	src/mds/SessionMap.cc
	src/common/options.cc
mds: allow request load average decay rate configurable via admin socket
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 3809d96)

 Conflicts:
	src/mds/MDSDaemon.cc
	src/mds/MDSRank.h
mds: show session load average in dump session
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 682dc08)
mds: track average uptime of sessions
Average session age math improvements by Patrick.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit d2627b9)

 Conflicts:
	src/mds/SessionMap.h
mds: include session uptime when diplaying session list
Fixes: https://tracker.ceph.com/issues/35938
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit b23a204)
mds: simplify beacon init
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit b7448f8)

 Conflicts:
	src/mds/Beacon.cc
mds: use monotonic clock in beacon
Also update other parts of MDS which interact.

Fixes: http://tracker.ceph.com/issues/35837
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit e77a2f5)

 Conflicts:
	src/mds/Beacon.cc
	src/mds/MDCache.h
	src/mds/MDSRank.cc
	src/mds/MDSRank.h
	src/mds/Server.cc
mds: use monotonic waits in Beacon
This guarantees that the sender thread cannot be disrupted by system clock
changes. This commit also simplifies the sender thread by manually managing the
thread and avoiding unnecessary context creation.

Fixes: http://tracker.ceph.com/issues/32090
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit a5fc29b)

 Conflicts:
	src/mds/Beacon.cc

@vshankar vshankar force-pushed the vshankar:wip-26991 branch from a45cfb7 to 56c730b Nov 6, 2018

@vshankar

This comment has been minimized.

Copy link
Contributor

vshankar commented Nov 6, 2018

rebased and updated

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 7, 2018

@vshankar vshankar self-assigned this Nov 12, 2018

@yuriw

yuriw approved these changes Nov 12, 2018

Copy link
Contributor

yuriw left a comment

Reviewed-by:  Venky Shankar vshankar@redhat.com

@yuriw yuriw merged commit d1e43d9 into ceph:mimic Nov 12, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@vshankar vshankar deleted the vshankar:wip-26991 branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment