New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: fsck: cid is improperly matched to oid #24480

Merged
merged 4 commits into from Oct 22, 2018

Conversation

Projects
None yet
6 participants
@pdvian
Copy link

pdvian commented Oct 8, 2018

liewegas added some commits Sep 13, 2018

osd/osd_types: fix pg_t::contains() to check pool id too
This is used by bluestore fsck to ensure we're looking at the right
collection.  It needs to validate both that the pool id matches the
object (including the temp objects) and that the hash matches; we were
only checking the hash before.

Fixes: http://tracker.ceph.com/issues/32731
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 0bd2546)
common/hobject: define get_temp_pool() etc helpers
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit cf4a4eb)
common/hobject: add get_logical_pool()
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 0c75020)

@smithfarm smithfarm added this to the mimic milestone Oct 9, 2018

@smithfarm smithfarm added the core label Oct 9, 2018

@smithfarm smithfarm requested review from tchaikov and xiexingguo Oct 9, 2018

@xiexingguo

This comment has been minimized.

Copy link
Member

xiexingguo commented Oct 9, 2018

Need to backport #24220 too

test/objectstore: set pool for fsck test
since 0bd2546, we check the pool id
of object when performing fsck to ensure we are looking at the right
collection, but the test is still using the pool id set by the
constructor of hobject_t. so all objects we created in that test belong
to the POOL_META. while the collection is created with the pool id of
`555`. hence the test fails.

Fixes: http://tracker.ceph.com/issues/36099
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8a814b2)
@xiexingguo

This comment has been minimized.

Copy link
Member

xiexingguo commented Oct 16, 2018

Need to backport #24220 too

Added!

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 17, 2018

@yuriw yuriw merged commit b147c10 into ceph:mimic Oct 22, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment