New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: Revert "mimic: cephfs-journal-tool: enable purge_queue journal's event commands" #24485

Merged
merged 4 commits into from Oct 30, 2018

Conversation

Projects
None yet
5 participants
@ukernel
Copy link
Member

ukernel commented Oct 9, 2018

Fixes: http://tracker.ceph.com/issues/36346

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

ukernel and others added some commits Oct 9, 2018

Revert "cephfs-journal-tool: enable purge_queue journal's event comma…
…nds"

This reverts commit 647899f. "In master,
this revert was executed by 65ae72a.

Fixes: http://tracker.ceph.com/issues/36346
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
cephfs-journal-tool: enable purge_queue journal's event commands
Resolves: http://tracker.ceph.com/issues/24604
Signed-off-by: Xuehan Xu <xuxuehan@360.cn>
(cherry picked from commit 5582fae)

 Conflicts:
	src/mds/PurgeQueue.h: Resvoled for decode
	src/tools/cephfs/JournalScanner.cc: Resolved in scan_events
mds: handle bad purge queue item encoding
The bad encoding was introduced by commit a88f8d5

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
@batrick

This comment has been minimized.

Copy link
Member

batrick commented Oct 9, 2018

ba06fcb looks reasonable to me. If we're not going to add that commit to master then we need to loudly broadcast on ceph-announce and in the PendingReleaseNotes that all users of 13.2.2 must upgrade to a later version of Mimic before any future upgrades to N+.

@batrick batrick changed the title Revert "mimic: cephfs-journal-tool: enable purge_queue journal's event commands" mimic: Revert "mimic: cephfs-journal-tool: enable purge_queue journal's event commands" Oct 9, 2018

@ukernel

This comment has been minimized.

Copy link
Member

ukernel commented Oct 10, 2018

We can add it to master later

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 23, 2018

doc: v13.2.3 release notes for wrong mds backport
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
* Ceph v13.2.2 includes a wrong backport, which may cause mds to go into
'damaged' state when upgrading Ceph cluster from previous version.
The bug is fixed in v13.2.3. For ceph v13.2.2 installation, upgrading
to v13.2.3 does not requires special action.

This comment has been minimized.

@smithfarm

smithfarm Oct 29, 2018

Contributor

Nit: s/does not requires/does not require any/

Thanks for the release note, @ukernel.

@yuriw yuriw merged commit 2a44ede into ceph:mimic Oct 30, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@ukernel ukernel deleted the ukernel:mimic-36346 branch Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment