pybind/ceph_argparse.py: do not create file for validating CephFilepath #24578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change, a file is opened with append mode for validating the specified CephFilepath argument. but this file is never removed after the validation. we cannot assume that this file will be overwritten or removed by the Ceph daemon who serves the command. after this change, no file is created for the validation, instead we check if the file is readable or writable. Signed-off-by: Kefu Chai <kchai@redhat.com>
|
retest this please. |
|
|
retest this please. |
neha-ojha
approved these changes
Oct 15, 2018
liewegas
added a commit
that referenced
this pull request
Oct 16, 2018
* refs/pull/24578/head: pybind/ceph_argparse.py: do not create file for validating CephFilepath Reviewed-by: Brad Hubbard <bhubbard@redhat.com> Reviewed-by: Neha Ojha <nojha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, a file is opened with append mode for validating the
specified CephFilepath argument. but this file is never removed after
the validation. we cannot assume that this file will be overwritten or
removed by the Ceph daemon who serves the command.
after this change, no file is created for the validation, instead we
check if the file is readable or writable.
Signed-off-by: Kefu Chai kchai@redhat.com