New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ec: src/common/interval_map.h: 161: FAILED assert(len > 0) #24581

Merged
merged 2 commits into from Oct 22, 2018

Conversation

Projects
None yet
3 participants

neha-ojha added some commits Sep 26, 2018

osd: print offset and length to track trimtrunc
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 07f7bd6)

Conflicts:
	src/osd/ECBackend.cc
- trivial: mimic uses assert() instead of ceph_assert()
osd/PrimaryLogPG.cc: reassign size only when object size > truncate_size
Before setting size equal to op.extent.truncate_size, we need to check
if the size of the object is greater than the truncate_size. We do not
need to set size to op.extent.truncate_size, in the case where the size of
the object is less than op.extent.truncate_size.

Without this change, we were always setting size =
op.extent.truncate_size, when (seq < op.extent.truncate_seq) and
(op.extent.offset + op.extent.length > op.extent.truncate_size), were both
true. This ended up in:

1. overestimating the size of the object
2. not considering the correct size of the object, for
   the later checks, which calculate op.extent.length for the read ops
3. causing crashes when trying to read more data than what was present

Fixes: http://tracker.ceph.com/issues/21931
Fixes: http://tracker.ceph.com/issues/22330

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 76c5781)

@smithfarm smithfarm requested review from neha-ojha and jdurgin Oct 15, 2018

@smithfarm smithfarm added this to the mimic milestone Oct 15, 2018

@smithfarm smithfarm added the core label Oct 15, 2018

@neha-ojha neha-ojha added the needs-qa label Oct 15, 2018

@neha-ojha

This comment has been minimized.

Copy link
Member

neha-ojha commented Oct 15, 2018

Note for QA: #24564 (comment)

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 17, 2018

@yuriw yuriw merged commit 6d9d604 into ceph:mimic Oct 22, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-36437-mimic branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment